Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When click on "View all" from favorite tab, get error #16988

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #16983

@jinghua-qa @rosemarie-chiu @stephenLYZ

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-10-06.at.7.44.42.AM.mov

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ
Copy link
Member

LGTM! Thanks for the fixing!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for also catching the chart one!

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #16988 (52ba6ba) into master (0b7704a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16988   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files        1030     1030           
  Lines       55022    55022           
  Branches     7465     7465           
=======================================
  Hits        42286    42286           
  Misses      12482    12482           
  Partials      254      254           
Flag Coverage Δ
javascript 70.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 73.17% <0.00%> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 64.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7704a...52ba6ba. Read the comment docs.

@michael-s-molina michael-s-molina merged commit c577191 into apache:master Oct 6, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.40

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 11, 2021
@eschutho eschutho added the v1.4 label Oct 26, 2021
eschutho pushed a commit to preset-io/superset that referenced this pull request Oct 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.40 size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Homepage Favorite tab] When click on "View all" from favorite tab, get error
6 participants