-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: skip unnecessary test steps #17005
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17005 +/- ##
==========================================
- Coverage 76.92% 76.85% -0.08%
==========================================
Files 1030 1030
Lines 55022 55035 +13
Branches 7465 7465
==========================================
- Hits 42328 42298 -30
- Misses 12440 12488 +48
+ Partials 254 249 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🏷 v1.4 |
(cherry picked from commit 9e980b6)
SUMMARY
There are two instances where we install Node and Python even if we can skip these tests. This should marginally speed up CI by avoiding unnecessary installation steps.
BEFORE
An example of Node being installed on a backend PR despite not needing to be installed (3 extra seconds):
Same for Python linting (no noticeable change in installation time, but still unnecessary):
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION