Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip unnecessary test steps #17005

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Oct 7, 2021

SUMMARY

There are two instances where we install Node and Python even if we can skip these tests. This should marginally speed up CI by avoiding unnecessary installation steps.

BEFORE

An example of Node being installed on a backend PR despite not needing to be installed (3 extra seconds):
image

Same for Python linting (no noticeable change in installation time, but still unnecessary):
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #17005 (87a5741) into master (1cd0124) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17005      +/-   ##
==========================================
- Coverage   76.92%   76.85%   -0.08%     
==========================================
  Files        1030     1030              
  Lines       55022    55035      +13     
  Branches     7465     7465              
==========================================
- Hits        42328    42298      -30     
- Misses      12440    12488      +48     
+ Partials      254      249       -5     
Flag Coverage Δ
hive 81.45% <ø> (+<0.01%) ⬆️
javascript 70.90% <ø> (-0.01%) ⬇️
mysql 81.90% <ø> (+<0.01%) ⬆️
postgres 81.91% <ø> (+<0.01%) ⬆️
presto ?
python 82.26% <ø> (-0.14%) ⬇️
sqlite 81.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 84.30% <0.00%> (-5.65%) ⬇️
superset/connectors/sqla/models.py 85.83% <0.00%> (-1.42%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
...frontend/src/SqlLab/components/ResultSet/index.tsx 61.48% <0.00%> (-0.46%) ⬇️
superset/utils/pandas_postprocessing.py 84.42% <0.00%> (ø)
superset-frontend/src/views/CRUD/hooks.ts 47.23% <0.00%> (ø)
superset-frontend/src/views/CRUD/utils.tsx 56.48% <0.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.35% <0.00%> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 73.17% <0.00%> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 64.89% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd0124...87a5741. Read the comment docs.

@villebro villebro changed the title [WIP] ci: fix broken test skips [WIP] ci: skip unnecessary test steps Oct 7, 2021
@villebro villebro changed the title [WIP] ci: skip unnecessary test steps ci: skip unnecessary test steps Oct 7, 2021
@zhaoyongjie zhaoyongjie self-requested a review October 8, 2021 06:11
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 9e980b6 into apache:master Oct 8, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@AAfghahi
Copy link
Member

🏷 v1.4

eschutho pushed a commit that referenced this pull request Nov 22, 2021
(cherry picked from commit 9e980b6)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants