-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gsheets): bug fix for private sheets #17019
fix(gsheets): bug fix for private sheets #17019
Conversation
b581655
to
acb8ed8
Compare
acb8ed8
to
3268727
Compare
3268727
to
0901e66
Compare
Codecov Report
@@ Coverage Diff @@
## master #17019 +/- ##
==========================================
- Coverage 76.72% 76.71% -0.01%
==========================================
Files 1030 1030
Lines 55088 55090 +2
Branches 7480 7481 +1
==========================================
Hits 42264 42264
- Misses 12573 12575 +2
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6019bdf
to
2667ee2
Compare
2667ee2
to
fc58b0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yousoph let's discuss user impersonation when we have the chance, and see if we should enable this by default for DBs that support it.
🏷 2021.40 |
(cherry picked from commit e32a12f)
(cherry picked from commit e32a12f)
SUMMARY
We weren't passing in impersonate_user as a payload in the front end so it was not allowing users to add private gsheets to datasets or to query them.
This also has a fix for a small 500 error that was occurring when editing a private gsheet. It was occurring because encrypted_extra is sometimes a string and sometimes a dict. I'm just running a simple check to make sure.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Create a new private gsheet and add a service key.
Go to sql lab
Query it
ADDITIONAL INFORMATION