-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error alerts again #17026
fix: error alerts again #17026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/testenv up |
@etr2460 Ephemeral environment spinning up at http://34.222.230.29:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #17026 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 1030 1030
Lines 55088 55088
Branches 7480 7480
=======================================
Hits 42383 42383
Misses 12454 12454
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
I guess this is what happens when I don't drink my coffee before coding. I didn't actually fix the bug in this first PR...
TESTING INSTRUCTIONS
CI, testenv this time
ADDITIONAL INFORMATION
to: @rusackas @graceguo-supercat @michael-s-molina