Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error alerts again #17026

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Oct 7, 2021

SUMMARY

I guess this is what happens when I don't drink my coffee before coding. I didn't actually fix the bug in this first PR...

TESTING INSTRUCTIONS

CI, testenv this time

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @rusackas @graceguo-supercat @michael-s-molina

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etr2460
Copy link
Member Author

etr2460 commented Oct 7, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

@etr2460 Ephemeral environment spinning up at http://34.222.230.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #17026 (d864af6) into master (03cdbac) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d864af6 differs from pull request most recent head eec669f. Consider uploading reports for the commit eec669f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17026   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files        1030     1030           
  Lines       55088    55088           
  Branches     7480     7480           
=======================================
  Hits        42383    42383           
  Misses      12454    12454           
  Partials      251      251           
Flag Coverage Δ
javascript 70.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/ErrorMessage/ErrorAlert.tsx 94.44% <ø> (ø)
...nd/src/components/ErrorMessage/BasicErrorAlert.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cdbac...eec669f. Read the comment docs.

@etr2460 etr2460 merged commit ea70038 into apache:master Oct 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Ephemeral environment shutdown and build artifacts deleted.

@villebro villebro added the v1.4 label Oct 12, 2021
@hughhhh hughhhh self-requested a review October 22, 2021 20:11
eschutho pushed a commit to preset-io/superset that referenced this pull request Oct 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants