Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show onhover menu only in edit mode #17034

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Oct 8, 2021

SUMMARY

This pr fixes issue where trash icon shows in markdown component when not in edit mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after
https://user-images.githubusercontent.com/17326228/136568990-52d48775-03d3-4d91-a73f-eab429402259.mov

TESTING INSTRUCTIONS

Trash icon should not show in markdown when not in edit mode.

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #17034 (e3cd30f) into master (9e980b6) will decrease coverage by 0.01%.
The diff coverage is 55.76%.

❗ Current head e3cd30f differs from pull request most recent head bf3c30d. Consider uploading reports for the commit bf3c30d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17034      +/-   ##
==========================================
- Coverage   76.94%   76.92%   -0.02%     
==========================================
  Files        1030     1031       +1     
  Lines       55088    55153      +65     
  Branches     7480     7500      +20     
==========================================
+ Hits        42385    42428      +43     
- Misses      12452    12473      +21     
- Partials      251      252       +1     
Flag Coverage Δ
javascript 70.88% <55.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 70.37% <33.33%> (-0.52%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 71.60% <35.71%> (-2.23%) ⬇️
.../src/explore/components/controls/SelectControl.jsx 77.61% <75.00%> (-1.08%) ⬇️
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx 85.71% <77.77%> (-0.96%) ⬇️
...e/components/controls/SelectAsyncControl/index.tsx 80.48% <80.00%> (-0.60%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 89.34% <88.00%> (+0.77%) ⬆️
...nents/ErrorMessage/DatasetNotFoundErrorMessage.tsx 88.88% <88.88%> (ø)
...c/dashboard/components/gridComponents/Markdown.jsx 83.49% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e980b6...bf3c30d. Read the comment docs.

@pkdotson pkdotson merged commit bdbcfbc into apache:master Oct 8, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix on markdown hover menu

* lint-fix
@AAfghahi
Copy link
Member

🏷 v1.4

eschutho pushed a commit that referenced this pull request Nov 22, 2021
* fix on markdown hover menu

* lint-fix
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* fix on markdown hover menu

* lint-fix
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard][markdown] User can remove markdown component in dashboard view mode
4 participants