-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show onhover menu only in edit mode #17034
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17034 +/- ##
==========================================
- Coverage 76.94% 76.92% -0.02%
==========================================
Files 1030 1031 +1
Lines 55088 55153 +65
Branches 7480 7500 +20
==========================================
+ Hits 42385 42428 +43
- Misses 12452 12473 +21
- Partials 251 252 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fix on markdown hover menu * lint-fix
🏷 v1.4 |
* fix on markdown hover menu * lint-fix
* fix on markdown hover menu * lint-fix
SUMMARY
This pr fixes issue where trash icon shows in markdown component when not in edit mode.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
https://user-images.githubusercontent.com/17326228/136568990-52d48775-03d3-4d91-a73f-eab429402259.mov
TESTING INSTRUCTIONS
Trash icon should not show in markdown when not in edit mode.
ADDITIONAL INFORMATION