-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Loading indicator of table and schema selectors #17040
fix: Loading indicator of table and schema selectors #17040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Codecov Report
@@ Coverage Diff @@
## master #17040 +/- ##
==========================================
- Coverage 76.70% 76.69% -0.01%
==========================================
Files 1031 1031
Lines 55155 55163 +8
Branches 7499 7501 +2
==========================================
+ Hits 42307 42309 +2
- Misses 12596 12602 +6
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷️ 2021.40 |
(cherry picked from commit 7c1c89c)
(cherry picked from commit 7c1c89c)
SUMMARY
Fixes the loading indicatos in
TableSelector
.@serenajiang
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-10-08.at.3.35.45.PM.mov
Screen.Recording.2021-10-08.at.3.33.32.PM.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION