Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Filter-sets): connect to api #17055

Merged
merged 26 commits into from
Oct 17, 2021
Merged

Conversation

simcha90
Copy link
Contributor

This PR migrate work with filtersets from working with dashboard metadata to filtersets api, it includes support for 4 requests:

  1. GET: get list of available filtersets
  2. POST: create new filterset
  3. PUT: Update existing filterset
  4. DELETE: Removing existing filterset

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #17055 (50d1afe) into master (40b88f0) will decrease coverage by 0.01%.
The diff coverage is 42.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17055      +/-   ##
==========================================
- Coverage   76.91%   76.89%   -0.02%     
==========================================
  Files        1038     1038              
  Lines       55486    55515      +29     
  Branches     7560     7564       +4     
==========================================
+ Hits        42676    42690      +14     
- Misses      12560    12575      +15     
  Partials      250      250              
Flag Coverage Δ
hive 81.44% <ø> (ø)
javascript 70.90% <42.00%> (-0.03%) ⬇️
mysql 81.90% <ø> (ø)
postgres 81.91% <ø> (ø)
presto 81.77% <ø> (ø)
python 82.41% <ø> (ø)
sqlite 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.70% <ø> (+0.01%) ⬆️
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 88.88% <0.00%> (-4.14%) ⬇️
.../nativeFilters/FilterBar/FilterSets/utils/index.ts 100.00% <ø> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx 0.00% <0.00%> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts 62.16% <0.00%> (+2.16%) ⬆️
superset-frontend/src/dashboard/reducers/types.ts 0.00% <ø> (ø)
superset/config.py 91.47% <ø> (ø)
...et-frontend/src/dashboard/actions/nativeFilters.ts 48.23% <33.33%> (-5.34%) ⬇️
...nents/nativeFilters/FilterBar/FilterSets/index.tsx 47.42% <37.03%> (+0.95%) ⬆️
...nativeFilters/FilterBar/FilterSets/EditSection.tsx 85.41% <100.00%> (+5.02%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b88f0...50d1afe. Read the comment docs.

@amitmiran137 amitmiran137 changed the title feat: Filtersets connect api feat(Filter-sets): connect to api Oct 11, 2021
@simcha90 simcha90 requested a review from villebro October 12, 2021 06:36
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work @simcha90 and @ofekisr for making this huge leap forward for filter sets! 🎉 Tested and works really well. This needs a rebase, so while doing that would you mind adding a comment to config.py next to the feature flag stating that this feature is under active development and breaking changes are expected? Also, next we should probably start adding RTL tests to this feature if we're happy with the related components.

@simcha90 simcha90 merged commit 37944e1 into apache:master Oct 17, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix:fix get permission function

* feat: filtersets new

* feat: connect filter sets to api

* lint: fix lint

* doc: add comment
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants