-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Filter-sets): connect to api #17055
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #17055 +/- ##
==========================================
- Coverage 76.91% 76.89% -0.02%
==========================================
Files 1038 1038
Lines 55486 55515 +29
Branches 7560 7564 +4
==========================================
+ Hits 42676 42690 +14
- Misses 12560 12575 +15
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great work @simcha90 and @ofekisr for making this huge leap forward for filter sets! 🎉 Tested and works really well. This needs a rebase, so while doing that would you mind adding a comment to config.py
next to the feature flag stating that this feature is under active development and breaking changes are expected? Also, next we should probably start adding RTL tests to this feature if we're happy with the related components.
� Conflicts: � superset-frontend/src/dashboard/containers/DashboardPage.tsx
* fix:fix get permission function * feat: filtersets new * feat: connect filter sets to api * lint: fix lint * doc: add comment
This PR migrate work with filtersets from working with dashboard metadata to filtersets api, it includes support for 4 requests:
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION