fix: accept headers on import #17080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
approved these changes
Oct 12, 2021
hughhhh
approved these changes
Oct 13, 2021
eschutho
approved these changes
Oct 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #17080 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 1031 1031
Lines 55183 55183
Branches 7505 7505
=======================================
Hits 42430 42430
Misses 12501 12501
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
reviewed
Oct 13, 2021
| wrapper.find(Button).at(2).simulate('click'); | ||
| await waitForComponentToPaint(wrapper); | ||
| expect(fetchMock.calls(DATABASE_IMPORT_URL)[0][1]?.headers).toStrictEqual({ | ||
| Accept: 'application/json', |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: accept headers on import * Add unit test
eschutho
pushed a commit
that referenced
this pull request
Nov 23, 2021
* fix: accept headers on import * Add unit test (cherry picked from commit 40e9add)
mistercrunch
added
🍒 1.4.0
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When importing an asset (dashboard, chart, etc.) we should specify an
Acceptrequest header to prevent the pretty 500 page from showing up.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION