Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update package-lock.json of superset-frontend and cypress-base #17125

Merged
merged 5 commits into from
Oct 15, 2021
Merged

fix: Update package-lock.json of superset-frontend and cypress-base #17125

merged 5 commits into from
Oct 15, 2021

Conversation

lyndsiWilliams
Copy link
Member

@lyndsiWilliams lyndsiWilliams commented Oct 15, 2021 •
edited
Loading

SUMMARY

Quick fix for the package-lock.json of superset-frontend and cypress-base

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams force-pushed the lyndsi/cypress-7-migration branch from 6a80bdc to fbe122a Compare October 15, 2021 00:45
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #17125 (fbe122a) into master (732e589) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17125   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files        1031     1031           
  Lines       55213    55213           
  Branches     7505     7505           
=======================================
  Hits        42439    42439           
  Misses      12524    12524           
  Partials      250      250
Flag Coverage Δ
javascript 70.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732e589...fbe122a. Read the comment docs.

@lyndsiWilliams lyndsiWilliams changed the title fix: superset-ui and package-lock fix: Update package-lock.json of superset-frontend and cypress-base Oct 15, 2021
@eschutho eschutho merged commit 5253193 into apache:master Oct 15, 2021
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/cypress-7-migration branch October 15, 2021 01:30
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@lyndsiWilliams
fix: Update package-lock.json of superset-frontend and cypress-base (a…
a4d6a70 
…pache#17125)

* Copied changes from original PR, minus package-lock.json files

* Reverted command name change

* Fixing superset-ui and package-lock.json

* superset-ui to 0.18.12

* Update cypress package-lock
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyndsiWilliams @eschutho @mistercrunch