Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prettier to pre-commit workflow #17134

Merged
merged 3 commits into from
Oct 21, 2021
Merged

feat: Add prettier to pre-commit workflow #17134

merged 3 commits into from
Oct 21, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 15, 2021

SUMMARY

Add prettier to check specific frontend files formatting stays consistent with each commit

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #17134 (f318ab9) into master (5253193) will decrease coverage by 0.24%.
The diff coverage is 70.22%.

❗ Current head f318ab9 differs from pull request most recent head af91bfb. Consider uploading reports for the commit af91bfb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17134      +/-   ##
==========================================
- Coverage   76.94%   76.69%   -0.25%     
==========================================
  Files        1031     1038       +7     
  Lines       55213    55557     +344     
  Branches     7505     7567      +62     
==========================================
+ Hits        42484    42610     +126     
- Misses      12479    12697     +218     
  Partials      250      250              
Flag Coverage Δ
hive ?
javascript 70.93% <69.77%> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.70% <ø> (+0.01%) ⬆️
...ilters/FilterBar/FilterConfigurationLink/index.tsx 100.00% <ø> (ø)
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 88.88% <0.00%> (-4.14%) ⬇️
.../nativeFilters/FilterBar/FilterSets/utils/index.ts 100.00% <ø> (ø)
...mponents/nativeFilters/FiltersConfigModal/state.ts 81.25% <0.00%> (+4.77%) ⬆️
...rontend/src/dashboard/containers/DashboardPage.tsx 0.00% <0.00%> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts 62.16% <0.00%> (+2.16%) ⬆️
superset-frontend/src/dashboard/reducers/types.ts 0.00% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 57.69% <ø> (ø)
...controls/FilterControl/AdhocFilterOption/index.jsx 100.00% <ø> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5253193...af91bfb. Read the comment docs.

@hughhhh hughhhh changed the title fix: prettier feat: Add prettier to pre-commit workflow Oct 18, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the slow review on this!

@hughhhh hughhhh merged commit cd9e994 into master Oct 21, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hugh/pc branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants