Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(doc): Update BigQuery Connection database connection UI into doc #17191

Merged
merged 4 commits into from
Oct 29, 2021
Merged

chore(doc): Update BigQuery Connection database connection UI into doc #17191

merged 4 commits into from
Oct 29, 2021

Conversation

rosemarie-chiu
Copy link
Contributor

Update BigQuery Connection database connection UI

SUMMARY

  • Update BigQuery connection instruction with database connection UI
  • Add database connect gif

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rosemarie-chiu
Update google-bigquery.mdx
8072158 
Update BigQuery Connection database connection UI
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 21, 2021
@junlincc junlincc requested review from pkdotson and srinify October 21, 2021 21:30
rosemarie-chiu and others added 2 commits October 22, 2021 23:29
@rosemarie-chiu @geido
fix grammar
e62ba5f 
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
@rosemarie-chiu @geido
fix grammar
d24e645 
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
@rosemarie-chiu rosemarie-chiu requested a review from geido October 22, 2021 15:29
srinify
srinify approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@srinify srinify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@srinify srinify merged commit ca6a1ec into apache:master Oct 29, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@rosemarie-chiu @geido @AAfghahi
chore(doc): Update BigQuery Connection database connection UI into doc (
8110074 
#17191)

* Update google-bigquery.mdx

Update BigQuery Connection database connection UI

* fix grammar

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* fix grammar

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* pre-commit prettier

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junlincc junlincc junlincc approved these changes

@srinify srinify srinify approved these changes

@pkdotson pkdotson Awaiting requested review from pkdotson

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:QA Preset QA team size/M 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosemarie-chiu @srinify @geido @junlincc @mistercrunch