fix(reports): Owners no longer showing undefined in reports

[lyndsiWilliams]

SUMMARY

"undefined undefined" was showing up in the owners list of a report every time it was edited. This was resolved by setting the owners data to match the state in alert (straight from redux state) instead of resource (coming from the alert fetch logic). Since resource is manipulated in the update, sometimes owners will be a list of owner IDs with no other data. This caused the label to return "undefined" for first_name and last_name in the owners object when it's updated. alert's state, however, consistently has the entire owners object. It now updates appropriately when updating the owners on a report.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

• Create and save a report
• Edit the report and add another owner
• Save changes
• Go back and edit report again
• Observe that all owners are displaying correctly, no instances of "undefined undefined"

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17223 (e042174) into master (029ed90) will increase coverage by 0.09%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #17223      +/-   ##
==========================================
+ Coverage   76.91%   77.01%   +0.09%     
==========================================
  Files        1039     1037       -2     
  Lines       55566    55636      +70     
  Branches     7570     7598      +28     
==========================================
+ Hits        42740    42848     +108     
+ Misses      12576    12538      -38     
  Partials      250      250              

Flag	Coverage Δ
javascript	71.14% <66.66%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx	60.70% <66.66%> (-0.44%)	⬇️
...erset-frontend/src/components/Pagination/index.tsx	72.72% <0.00%> (-27.28%)	⬇️
...nativeFilters/FiltersConfigModal/Footer/Footer.tsx	90.90% <0.00%> (-9.10%)	⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx	94.87% <0.00%> (-5.13%)	⬇️
...tend/src/filters/components/Select/controlPanel.ts	58.33% <0.00%> (-3.21%)	⬇️
superset/reports/api.py	85.92% <0.00%> (-2.54%)	⬇️
...frontend/src/dashboard/components/Header/index.jsx	68.30% <0.00%> (-0.41%)	⬇️
...et-frontend/src/components/TableSelector/index.tsx	74.28% <0.00%> (-0.25%)	⬇️
...tend/src/explore/components/ExploreChartHeader.jsx	6.84% <0.00%> (-0.20%)	⬇️
... and 57 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029ed90...e042174. Read the comment docs.

[betodealmeida]

Talked offline. We shouldn't modify the API to solve this, since it's strictly a frontend problem — the GET request before an edit already receives all the owners information correctly.

[eschutho]

FYI, for reference: https://github.com/apache/superset/pull/17167/files

[betodealmeida]

Looks good!

It would be nice to fix resource so that it's behaving consistently, but I think this is ok for now.

[lyndsiWilliams]

Looks good!

It would be nice to fix resource so that it's behaving consistently, but I think this is ok for now.

Agreed, state could use some cleanup here to avoid future complications.