Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove variables from styled component #17228

Merged
merged 2 commits into from
Nov 2, 2021
Merged

fix: remove variables from styled component #17228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea2cd3f
remove variables
pkdotson Oct 26, 2021
43cc98b
fix hovermenu styles
pkdotson Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,16 @@ const StyledDiv = styled.div`
/* A row within a column has inset hover menu */
.dragdroppable-column .dragdroppable-row .hover-menu--left {
left: -12px;
background: @lightest;
border: 1px solid @gray-light;
background: ${({ theme }) => theme.colors.grayscale.light5};
border: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
}

/* A column within a column or tabs has inset hover menu */
.dragdroppable-column .dragdroppable-column .hover-menu--top,
.dashboard-component-tabs .dragdroppable-column .hover-menu--top {
top: -12px;
background: @lightest;
border: 1px solid @gray-light;
background: ${({ theme }) => theme.colors.grayscale.light5};
border: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
}

/* move Tabs hover menu to top near actual Tabs */
Expand Down
18 changes: 9 additions & 9 deletions superset-frontend/src/dashboard/components/menu/HoverMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,32 +30,32 @@ const HoverStyleOverrides = styled.div`
.hover-menu {
opacity: 0;
position: absolute;
z-index: @z-index-above-dashboard-charts;
font-size: @font-size-m;
z-index: 10;
font-size: ${({ theme }) => theme.typography.sizes.m};
}

.hover-menu--left {
width: 24px;
width: ${({ theme }) => theme.gridUnit * 6}px;
top: 50%;
transform: translate(0, -50%);
left: -28px;
padding: 8px 0;
left: ${({ theme }) => theme.gridUnit * -7}px;
padding: ${({ theme }) => theme.gridUnit * 2}px 0;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
}

.hover-menu--left > :nth-child(n):not(:only-child):not(:last-child) {
margin-bottom: 12px;
margin-bottom: ${({ theme }) => theme.gridUnit * 3}px;
}

.hover-menu--top {
height: 24px;
top: -24px;
height: ${({ theme }) => theme.gridUnit * 6}px;
top: ${({ theme }) => theme.gridUnit * -6}px;
left: 50%;
transform: translate(-50%);
padding: 0 8px;
padding: 0 ${({ theme }) => theme.gridUnit * 2}px;
display: flex;
flex-direction: row;
justify-content: center;
Expand Down