-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Test cases for annotations and annotation layers incorrect creation through API #17246
chore: Test cases for annotations and annotation layers incorrect creation through API #17246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17246 +/- ##
==========================================
+ Coverage 76.96% 76.98% +0.01%
==========================================
Files 1037 1037
Lines 55608 55617 +9
Branches 7588 7588
==========================================
+ Hits 42800 42818 +18
+ Misses 12558 12549 -9
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but will let @dpgaspar give the final verdict as he originally requested the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness add 1 more test for update, making sure we can update a single field, since no field is required on PUTs
…ation through API (#17246) * Add/Refactor tests * Add return type * Update api tests
SUMMARY
This is a follow-up PR based on this request #17234 (review).
It moves the integration tests that work best as unit tests and adds test cases to cover the creation of incorrect annotations and annotation layers through the API
Thanks @villebro for guiding me through this!
ADDITIONAL INFORMATION