fix(sqllab): Bugfix for tracking url transformation

[CodeingBoy]

SUMMARY

This is a bugfix for #17262, review this issue for more information.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Create sample data table in Hive:

CREATE TABLE some_table(
    a INT,
    b STRING
);
INSERT INTO some_table(a, b) VALUES (1, '1'), (2, '2'), (3, '3'), (4, '4');

2. Execute query SELECT a, COUNT(1) AS count FROM some_table GROUP BY a;, it should not report error and return results

ADDITIONAL INFORMATION

• Has associated issue: Fixes Complex query with Hive will cause errors #17262
• Required feature flags: no
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

Code change looks LGTM, thanks for fixing! However, I believe you will need to fix linting, as this change will exceed the maximum line width.

[villebro]

Linking to original PR that introduced the regression: #14366

[codecov]

Codecov Report

Merging #17263 (e6ab6f2) into master (b5246b2) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #17263      +/-   ##
==========================================
+ Coverage   76.94%   76.96%   +0.02%     
==========================================
  Files        1039     1039              
  Lines       55608    55597      -11     
  Branches     7580     7580              
==========================================
+ Hits        42786    42793       +7     
+ Misses      12572    12554      -18     
  Partials      250      250              

Flag	Coverage Δ
hive	81.54% <0.00%> (+0.07%)	⬆️
mysql	81.97% <0.00%> (+0.04%)	⬆️
postgres	81.98% <0.00%> (+0.04%)	⬆️
presto	81.85% <0.00%> (+0.05%)	⬆️
python	82.48% <0.00%> (+0.05%)	⬆️
sqlite	81.65% <0.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/hive.py	86.48% <0.00%> (-0.34%)	⬇️
superset/connectors/sqla/models.py	87.39% <0.00%> (-0.09%)	⬇️
superset/config.py	91.50% <0.00%> (ø)
superset/utils/core.py	90.14% <0.00%> (ø)
superset/views/core.py	76.95% <0.00%> (+0.01%)	⬆️
superset/db_engine_specs/presto.py	90.37% <0.00%> (+0.41%)	⬆️
superset/cli.py	54.92% <0.00%> (+2.07%)	⬆️
superset/views/database/forms.py	94.44% <0.00%> (+7.34%)	⬆️
superset/annotation_layers/annotations/schemas.py	100.00% <0.00%> (+13.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5246b2...e6ab6f2. Read the comment docs.

[CodeingBoy]

Hi @villebro, I have fixed linting by splitting into two statements. Is that OK?

[villebro]

LGTM