Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate DragHandle component from jsx to tsx #17326

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

Damans227
Copy link
Contributor

@Damans227 Damans227 commented Nov 2, 2021

SUMMARY

PR for migrating DragHandle functional react component from JSX to TSX

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [TRACKER] Migrate JavaScript files to TypeScript #10004
  • Enhancement (new features, refinement)
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Damans227
Copy link
Contributor Author

@etr2460 Ptal, thx!

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #17326 (d8dbf0b) into master (a2a457b) will increase coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17326      +/-   ##
==========================================
+ Coverage   76.87%   76.96%   +0.08%     
==========================================
  Files        1037     1037              
  Lines       55647    55654       +7     
  Branches     7608     7618      +10     
==========================================
+ Hits        42779    42833      +54     
+ Misses      12618    12566      -52     
- Partials      250      255       +5     
Flag Coverage Δ
javascript 71.43% <90.90%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/dashboard/components/dnd/DragHandle.tsx 90.90% <90.90%> (ø)
...et-frontend/src/dashboard/components/Dashboard.jsx 78.09% <0.00%> (-3.80%) ⬇️
.../src/dashboard/components/BuilderComponentPane.tsx 96.87% <0.00%> (-3.13%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 52.76% <0.00%> (ø)
superset-frontend/src/views/CRUD/utils.tsx 56.48% <0.00%> (ø)
superset-frontend/src/dashboard/util/constants.ts 100.00% <0.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.35% <0.00%> (ø)
...end/src/visualizations/FilterBox/transformProps.ts 6.66% <0.00%> (ø)
...c/SqlLab/components/RunQueryActionButton/index.tsx 65.11% <0.00%> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a457b...d8dbf0b. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 3, 2021
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! if you wanted to make this as functional component too, i wouldn't complain. but that doesn't need to be addressed

@Damans227 Damans227 force-pushed the enhancement/migrate-jsx-to-tsx_3 branch from c70478a to fd1c2fe Compare November 3, 2021 16:59
@Damans227
Copy link
Contributor Author

lgtm! if you wanted to make this as functional component too, i wouldn't complain. but that doesn't need to be addressed

Sure, will give it a shot. :)

@pull-request-size pull-request-size bot added size/L and removed size/S labels Nov 3, 2021
@Damans227 Damans227 requested a review from etr2460 November 3, 2021 17:19
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@villebro
Copy link
Member

Thanks for this improvement @Damans227 !

@villebro villebro merged commit cf3f0e5 into apache:master Nov 25, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants