fix: add fallback and validation for report and cron timezones #17338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17338 +/- ##
==========================================
- Coverage 77.01% 76.96% -0.05%
==========================================
Files 1040 1041 +1
Lines 56074 56070 -4
Branches 7735 7735
==========================================
- Hits 43188 43157 -31
- Misses 12628 12655 +27
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
force-pushed
the
elizabeth/timezone-error
branch
from
a185067 to
b208ded
Compare
betodealmeida
approved these changes
Nov 3, 2021
| timezone = fields.String( | ||
| description=timezone_description, | ||
| default="UTC", | ||
| validate=validate.OneOf(choices=tuple(all_timezones)), |
eschutho
force-pushed
the
elizabeth/timezone-error
branch
from
df6f550 to
6c58a3b
Compare
eschutho
force-pushed
the
elizabeth/timezone-error
branch
from
6c58a3b to
07e11fd
Compare
eschutho
added a commit
that referenced
this pull request
Nov 22, 2021
* add fallback and validation for report and cron timezones * add logging to exception catch * Run black Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> (cherry picked from commit f10bc6d)
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* add fallback and validation for report and cron timezones * add logging to exception catch * Run black Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
mistercrunch
added
🍒 1.4.0
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It was possible for short period of time to save an invalid timezone value (GMT Standard Time) in the reports schedule, which was causing errors and failures when running the cron job. With this change, I am catching any cron errors with regard to the timezone function and defaulting to UTC. I also added timezone validation when creating a report.
TESTING INSTRUCTIONS
unit and integration tests have been updated. To manually test, you should be able to create and run a report with a timezone. You should not be able to create a report with a bad timezone.
ADDITIONAL INFORMATION