Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ChartDataCommand): into two separate commands #17425

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Nov 12, 2021

Background

When we have worked on #16991 we wanted to test the new functionalities in concrete and accurate unittest.
All chartData flows and its components are too couple to superset so it is impossible to create unittests.
The flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty

So I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes into small PRs so will be easier to follow

This is the fifth PR in a sequence of PRs to meet these
The next PR is #17461

PR description

  1. Moves the commands module to be under charts.data package
  2. Retrieving data and creating retrieve data job are two different responsibilities, so they should be in separate commands so the PR split it.

Note - The pr consists of the #17407 commit until it will be merged then I'll recreate the branch from master

Test plans

There are no logic changes so new tests are not required

Previous PRs

  1. refactor(ChartData): move ChartDataResult enums to common #17399
  2. refactor(ChartData): move chart_data_apis from ChartRestApi ChartDataRestApi #17400
  3. refactor(ChartDataCommand): separate loading query_context form cache into different module #17405
  4. refactor(TestChartApi): move chart data api tests into TestChartDataApi #17407

@ofekisr ofekisr marked this pull request as draft November 14, 2021 20:20
@ofekisr ofekisr force-pushed the refactor/chart_data_flows_5 branch from 4dde8ae to 25da471 Compare November 14, 2021 21:53
@ofekisr ofekisr marked this pull request as ready for review November 14, 2021 21:53
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separation looks clean !

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #17425 (25da471) into master (d8851c9) will decrease coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17425      +/-   ##
==========================================
- Coverage   76.97%   76.97%   -0.01%     
==========================================
  Files        1041     1041              
  Lines       56069    56068       -1     
  Branches     7742     7742              
==========================================
- Hits        43157    43156       -1     
  Misses      12654    12654              
  Partials      258      258              
Flag Coverage Δ
hive 81.52% <94.11%> (-0.01%) ⬇️
mysql 81.95% <94.11%> (-0.01%) ⬇️
postgres 81.95% <94.11%> (-0.01%) ⬇️
python 82.31% <94.11%> (-0.01%) ⬇️
sqlite 81.63% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/data/api.py 88.57% <85.71%> (+0.08%) ⬆️
superset/charts/data/commands.py 97.87% <100.00%> (ø)
superset/tasks/async_queries.py 96.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8851c9...25da471. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants