Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Column for select tabs to send #17604

Conversation

m-ajay
Copy link
Contributor

@m-ajay m-ajay commented Nov 30, 2021

As of now, users can only send the first tab of the dashboard. We are improving the feature, to let the user select the tabs to send. Please see the discussion here #14056 .

This PR adds a new column to Report schedule, initially this will be used to store the IDs of the tabs to send.

SUMMARY

Second PR will include letting users select the tabs of the dashboards to send.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@m-ajay m-ajay changed the title Feat/alerts select tabs to send migration feat(alerts): Column for select tabs to send Dec 1, 2021
@m-ajay m-ajay marked this pull request as ready for review December 1, 2021 17:51
@m-ajay m-ajay requested a review from a team as a code owner December 1, 2021 17:51
@graceguo-supercat
Copy link

@m-ajay Thanks for the work!
Currently, we want to enrich the email report feature with dashboard tab selection. But in the very near future, we might want to enrich the report with filter set selection, or dashboard_owners etc. So i think all these extra configuration for a report, could be stored in the same column that you will add today.

So how about name this column as extra_config, column type Text is good, and will populate an empty json {} text as default data?

@dpgaspar
Copy link
Member

dpgaspar commented Dec 2, 2021

@m-ajay can you please update the PR description and fix CI, seems like a mig issue

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #17604 (b45db18) into master (c6ba9bf) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17604      +/-   ##
==========================================
+ Coverage   68.48%   68.55%   +0.06%     
==========================================
  Files        1601     1601              
  Lines       65268    65273       +5     
  Branches     6966     6966              
==========================================
+ Hits        44698    44747      +49     
+ Misses      18680    18636      -44     
  Partials     1890     1890              
Flag Coverage Δ
hive 81.38% <100.00%> (+<0.01%) ⬆️
mysql 81.80% <100.00%> (+<0.01%) ⬆️
postgres 81.81% <100.00%> (+<0.01%) ⬆️
presto 81.68% <100.00%> (?)
python 82.30% <100.00%> (+0.15%) ⬆️
sqlite 81.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/alerts.py 97.33% <ø> (ø)
superset/models/reports.py 100.00% <100.00%> (ø)
superset/charts/schemas.py 99.33% <0.00%> (+<0.01%) ⬆️
superset/datasets/schemas.py 96.61% <0.00%> (+0.08%) ⬆️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.34%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ba9bf...b45db18. Read the comment docs.

@etr2460
Copy link
Member

etr2460 commented Dec 2, 2021

should we use extra for the column name instead of extra_config, to be consistent with other tables in superset?

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 1377465 into apache:master Dec 3, 2021
sadpandajoe added a commit to preset-io/superset that referenced this pull request Dec 7, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants