-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): Column for select tabs to send #17604
feat(alerts): Column for select tabs to send #17604
Conversation
@m-ajay Thanks for the work! So how about name this column as |
@m-ajay can you please update the PR description and fix CI, seems like a mig issue |
Codecov Report
@@ Coverage Diff @@
## master #17604 +/- ##
==========================================
+ Coverage 68.48% 68.55% +0.06%
==========================================
Files 1601 1601
Lines 65268 65273 +5
Branches 6966 6966
==========================================
+ Hits 44698 44747 +49
+ Misses 18680 18636 -44
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
should we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 1377465.
As of now, users can only send the first tab of the dashboard. We are improving the feature, to let the user select the tabs to send. Please see the discussion here #14056 .
This PR adds a new column to Report schedule, initially this will be used to store the IDs of the tabs to send.
SUMMARY
Second PR will include letting users select the tabs of the dashboards to send.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION