fix(Mixed Timeseries Chart): Custom Metric Label

[Yahyakiani]

SUMMARY

Bug Fix
This PR fixes the problem in which custom metric name is shown in legend instead of custom metric label inside Mixed Time series charts. Reference: Issue #17586

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Fixes [mixed time-series] Metric name is shown in legend instead of label #17586
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[stephenLYZ]

LGTM. Thanks for the fix!

[zhaoyongjie]

Hi @Yahyakiani , Thanks for the fix. Could you mind fixing the lint?

[Yahyakiani]

Hi @Yahyakiani , Thanks for the fix. Could you mind fixing the lint?

Is anything else required on this issue ?

[zhaoyongjie]

Is anything else required on this issue ?

The CI need to be fixed.

[Yahyakiani]

Is anything else required on this issue ?

The CI need to be fixed.

What steps could I perform to resolve it? Because I have tried running lint but it seems to make no difference.

[villebro]

@Yahyakiani these linting errors are blocking CI:

Let me know if you need help resolving them

[Yahyakiani]

@Yahyakiani these linting errors are blocking CI: Let me know if you need help resolving them

@villebro Actually I ran lint locally multiple times. It seems to run without error and on saving the file there are no changes.

[villebro]

@Yahyakiani ok let me checkout your PR locally and see if I can repro the problem

[stephenLYZ]

@Yahyakiani hey, I think you may need to lint all files instead of one file under superset-frontend.

[villebro]

The issues aren't directly "linting" errors per se, but actually type errors. See my comment below.

[codecov]

Codecov Report

Merging #17649 (24ee345) into master (4306289) will decrease coverage by 0.84%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #17649      +/-   ##
==========================================
- Coverage   68.71%   67.87%   -0.85%     
==========================================
  Files        1596     1652      +56     
  Lines       65224    66263    +1039     
  Branches     6950     7122     +172     
==========================================
+ Hits        44817    44973     +156     
- Misses      18522    19393     +871     
- Partials     1885     1897      +12     

Flag	Coverage Δ
javascript	56.24% <0.00%> (-1.21%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts	11.45% <0.00%> (-0.37%)	⬇️
...rset-ui-core/src/connection/SupersetClientClass.ts	90.76% <0.00%> (-7.54%)	⬇️
...nd/src/explore/components/DataTablesPane/index.tsx	76.92% <0.00%> (-0.75%)	⬇️
...rc/explore/components/ExploreChartHeader/index.jsx	46.57% <0.00%> (-0.65%)	⬇️
...et-frontend/src/components/EditableTitle/index.tsx	73.07% <0.00%> (-0.61%)	⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx	21.34% <0.00%> (-0.50%)	⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx	38.53% <0.00%> (-0.36%)	⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	67.15% <0.00%> (-0.26%)	⬇️
superset-frontend/src/components/Select/Select.tsx	86.33% <0.00%> (ø)
...uperset-frontend/src/utils/getClientErrorObject.ts	71.87% <0.00%> (ø)
... and 67 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4306289...24ee345. Read the comment docs.

[villebro]

Fix seems mostly correct, but one question

[villebro]

LGTM, thanks for the fix and diligently iterating on this!