chore: add release to pip requirements #17752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/add-requests
branch
from
9645f88 to
cc03ab4
Compare
eschutho
force-pushed
the
elizabeth/add-requests
branch
from
c584e12 to
5f9f0b1
Compare
eschutho
force-pushed
the
elizabeth/add-requests
branch
5 times, most recently
from
d50e5af to
7e397ae
Compare
Codecov Report
@@ Coverage Diff @@
## 1.4 #17752 +/- ##
==========================================
+ Coverage 76.92% 82.01% +5.08%
==========================================
Files 1030 359 -671
Lines 55185 28968 -26217
Branches 7497 0 -7497
==========================================
- Hits 42452 23758 -18694
+ Misses 12476 5210 -7266
+ Partials 257 0 -257
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Dec 15, 2021
| @@ -27,7 +27,7 @@ repos: | |||
| rev: v0.910 | |||
| hooks: | |||
| - id: mypy | |||
| additional_dependencies: [types-all] | |||
| additional_dependencies: [types-all, types-redis] | |||
eschutho
force-pushed
the
elizabeth/add-requests
branch
2 times, most recently
from
8e3da00 to
cbd819a
Compare
eschutho
added a commit
that referenced
this pull request
Dec 22, 2021
* add requests to pip requirements * fix tests * add redis typing for mypy * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
1.4 builds were breaking because the package "requests" wasn't found. We call the package in `superset/utils/webdriver.py' so it makes sense that we are explicitly requiring the package.
I also fixed up some tests that weren't passing due to merge conflicts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION