Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miss-spelling on CONTRIBUTING.md line 1351 #17760

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

MayUWish
Copy link
Contributor

@MayUWish MayUWish commented Dec 15, 2021

SUMMARY

Correct miss-spelling <datasouce_id>__<datasource_type> to <datasource_id>__<datasource_type> on CONTRIBUTING.md line 1351

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member

Thanks for the contribution @MayUWish ! It appears you've mistakenly removed the package-lock.json file. Can you fix that first?

@AAfghahi AAfghahi changed the title fix miss-spelling on CONTRIBUTING.md line 1351 fix: miss-spelling on CONTRIBUTING.md line 1351 Dec 15, 2021
@AAfghahi
Copy link
Member

hey Meitong! I think you may have not run npm install that's why you don't have the package-lock.json. Also I think this will fail the lint test for your PR name. I changed it so that it will pass.

@AAfghahi AAfghahi changed the title fix: miss-spelling on CONTRIBUTING.md line 1351 chore: miss-spelling on CONTRIBUTING.md line 1351 Dec 15, 2021
@AAfghahi AAfghahi changed the title chore: miss-spelling on CONTRIBUTING.md line 1351 fix: miss-spelling on CONTRIBUTING.md line 1351 Dec 15, 2021
Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Meitong! +1 on the package.json, I believe you'll need to run npm ci in superset-frontend to fix this. Reach out on Slack or in office hours today if you'd like some help.

Could you also fill out the "Summary" portion of the description of your PR?

@AAfghahi AAfghahi dismissed lyndsiWilliams’s stale review December 15, 2021 21:01

she made the changes

@AAfghahi AAfghahi merged commit 71e4131 into apache:master Dec 15, 2021
@eschutho eschutho added the Superset-Community-Partners Preset community partner program participants label Jan 5, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* fix miss-spelling on CONTRIBUTING.md line 1351

* added superset-frontend/package-lock.json
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* fix miss-spelling on CONTRIBUTING.md line 1351

* added superset-frontend/package-lock.json
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS Superset-Community-Partners Preset community partner program participants 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants