Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change 401 response to a 403 for Security Exceptions #17768

Merged
merged 3 commits into from
Dec 16, 2021
Merged

fix: change 401 response to a 403 for Security Exceptions #17768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14045a1
fix: change 401 to 403 for Security Exceptions
rusackas Dec 15, 2021
79a6cc5
updating tests to reflect new (proper) status code
rusackas Dec 15, 2021
525ebf4
another test update
rusackas Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def __init__(


class SupersetSecurityException(SupersetErrorException):
status = 401
status = 403

def __init__(
self, error: SupersetError, payload: Optional[Dict[str, Any]] = None
Expand Down
4 changes: 2 additions & 2 deletions tests/integration_tests/charts/data/api_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,15 +464,15 @@ def test_with_invalid_time_range_endpoints_enum_value__400(self):

assert rv.status_code == 400

def test_with_not_permitted_actor__401(self):
def test_with_not_permitted_actor__403(self):
"""
Chart data API: Test chart data query not allowed
"""
self.logout()
self.login(username="gamma")
rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")

assert rv.status_code == 401
assert rv.status_code == 403
assert (
rv.json["errors"][0]["error_type"]
== SupersetErrorType.DATASOURCE_SECURITY_ACCESS_ERROR
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/dashboards/security/security_rbac_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_get_dashboard_view__user_can_not_access_without_permission(self):

request_payload = get_query_context("birth_names")
rv = self.post_assert_metric(CHART_DATA_URI, request_payload, "data")
self.assertEqual(rv.status_code, 401)
self.assertEqual(rv.status_code, 403)

# assert
self.assert403(response)
Expand Down