-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): update native filter info in metadata is not updated #17842
fix(dashboard): update native filter info in metadata is not updated #17842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17842 +/- ##
==========================================
- Coverage 67.15% 67.03% -0.13%
==========================================
Files 1608 1608
Lines 64798 64819 +21
Branches 6851 6852 +1
==========================================
- Hits 43518 43451 -67
- Misses 19421 19509 +88
Partials 1859 1859
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
SUMMARY
This PR fixes the problem that native filter is not displayed correctly after the user updates native filter information via json editor.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
dashboard.propterties.mov
after
2021-12-21.10.03.27.mov
TESTING INSTRUCTIONS
follow #17665
ADDITIONAL INFORMATION