Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show SCHEDULED_QUERIES template in SqlLab #17854

Merged
merged 1 commit into from
Dec 27, 2021
Merged

fix(ui): show SCHEDULED_QUERIES template in SqlLab #17854

merged 1 commit into from
Dec 27, 2021

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Dec 22, 2021

SUMMARY

SCHEDULED_QUERIES is not rendered in UI even when defined as a config. Probably a regression or omitted in PR #15254

Without this entry Schedule option for SqlLab will not be shown in UI since it will never be put under bootstrapData.common.conf needed in here

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Without this entry `Schedule` option for `SqlLab` will not be shown in UI since it will never be put under `bootstrapData.common.conf` needed in here https://github.com/apache/superset/blob/69f9ee8f5eddcf8ac7a8bfb697be4fc95f34e66b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L33
@cemremengu cemremengu changed the title fix: show SCHEDULED_QUERIES when defined fix: show SCHEDULED_QUERIES template in SqlLab when defined Dec 22, 2021
@cemremengu cemremengu changed the title fix: show SCHEDULED_QUERIES template in SqlLab when defined fix(ui): show SCHEDULED_QUERIES template in SqlLab when defined Dec 22, 2021
@cemremengu cemremengu changed the title fix(ui): show SCHEDULED_QUERIES template in SqlLab when defined fix(ui): show SCHEDULED_QUERIES template in SqlLab Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #17854 (3641860) into master (b7707e8) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17854      +/-   ##
==========================================
- Coverage   67.09%   66.90%   -0.19%     
==========================================
  Files        1609     1609              
  Lines       64865    64863       -2     
  Branches     6863     6863              
==========================================
- Hits        43518    43397     -121     
- Misses      19483    19602     +119     
  Partials     1864     1864              
Flag Coverage Δ
hive ?
mysql 82.18% <ø> (ø)
postgres 82.23% <ø> (ø)
presto ?
python 82.31% <ø> (-0.40%) ⬇️
sqlite 81.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 74.91% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.48%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
...uperset-frontend/src/explore/exploreUtils/index.js 66.42% <0.00%> (-0.48%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7707e8...3641860. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit c6c4143 into apache:master Dec 27, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
Without this entry `Schedule` option for `SqlLab` will not be shown in UI since it will never be put under `bootstrapData.common.conf` needed in here https://github.com/apache/superset/blob/69f9ee8f5eddcf8ac7a8bfb697be4fc95f34e66b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L33
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
Without this entry `Schedule` option for `SqlLab` will not be shown in UI since it will never be put under `bootstrapData.common.conf` needed in here https://github.com/apache/superset/blob/69f9ee8f5eddcf8ac7a8bfb697be4fc95f34e66b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants