-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): show SCHEDULED_QUERIES template in SqlLab #17854
Conversation
Without this entry `Schedule` option for `SqlLab` will not be shown in UI since it will never be put under `bootstrapData.common.conf` needed in here https://github.com/apache/superset/blob/69f9ee8f5eddcf8ac7a8bfb697be4fc95f34e66b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L33
Codecov Report
@@ Coverage Diff @@
## master #17854 +/- ##
==========================================
- Coverage 67.09% 66.90% -0.19%
==========================================
Files 1609 1609
Lines 64865 64863 -2
Branches 6863 6863
==========================================
- Hits 43518 43397 -121
- Misses 19483 19602 +119
Partials 1864 1864
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Without this entry `Schedule` option for `SqlLab` will not be shown in UI since it will never be put under `bootstrapData.common.conf` needed in here https://github.com/apache/superset/blob/69f9ee8f5eddcf8ac7a8bfb697be4fc95f34e66b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L33
Without this entry `Schedule` option for `SqlLab` will not be shown in UI since it will never be put under `bootstrapData.common.conf` needed in here https://github.com/apache/superset/blob/69f9ee8f5eddcf8ac7a8bfb697be4fc95f34e66b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx#L33
SUMMARY
SCHEDULED_QUERIES is not rendered in UI even when defined as a config. Probably a regression or omitted in PR #15254
Without this entry
Schedule
option forSqlLab
will not be shown in UI since it will never be put underbootstrapData.common.conf
needed in hereADDITIONAL INFORMATION