Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translation): include babel-compile in Dockerfile (#17876) #17877

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Dec 27, 2021

SUMMARY

Adds babel-compile step in Dockerfile.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
image

TESTING INSTRUCTIONS

  1. Enable a rather complete language in superset_config_docker.py:
BABEL_DEFAULT_LOCALE = "de"
LANGUAGES = {
    "de": {"flag": "de", "name": "Deutsch"},
    "en": {"flag": "us", "name": "English"},
}
  1. build docker images via docker build -t apache/superset:latest-dev .
  2. Start superset via docker-compose -f docker-compose-non-dev.yml' up -d
  3. Open http://localhost:8088/
  4. See formerly untranslated messages now translated

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Translation files are not compiled for docker images latest/latest-dev  #17876
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hbruch
Copy link
Contributor Author

hbruch commented Dec 29, 2021

@villebro Seems like there was a temporay problem with git checkout (?) Could you restart the checks (or could I do this myself?)

@hbruch hbruch force-pushed the fix/17876_babel_compile branch from 54aa4e4 to bf56c97 Compare January 4, 2022 14:19
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit e0bd937 into apache:master Jan 4, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation files are not compiled for docker images latest/latest-dev
3 participants