-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): scope status of filter not update in dashboard metadata #17945
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17945 +/- ##
==========================================
- Coverage 67.07% 67.06% -0.02%
==========================================
Files 1609 1609
Lines 64905 64915 +10
Branches 6868 6869 +1
==========================================
Hits 43537 43537
- Misses 19502 19512 +10
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_UX_BETA=true |
@jinghua-qa Ephemeral environment spinning up at http://54.187.239.26:8080. Credentials are |
Stephen I have tested the PR in the env, i saw some issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @jinghua-qa if you could give this a test bashing before we merge, that would be great!
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_UX_BETA=true |
@rusackas Ephemeral environment spinning up at http://54.212.84.149:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save (cherry picked from commit bd9e123)
🏷 2022.1 |
…ta (#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save
…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save
…ta (apache#17945) * fix(dashboard): scope status of filter not update in dashboard metadata * fix save
SUMMARY
This PR fixes the problem that the scope status of filter which adds to the dashboard is not updated in the dashboard json metadata, steps to reproduce:
chartsInScope
andfilterConfig
It will cause the incorrect scope status if we update the native filter via json metadata like this issue #17932
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2022-01-06.3.28.18.mov
after
2022-01-06.3.30.39.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION