Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: API logger output #17981

Merged
merged 6 commits into from
Jan 11, 2022
Merged

fix: API logger output #17981

merged 6 commits into from
Jan 11, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

Improve logger messages on core API

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #17981 (4249326) into master (ea3a583) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17981      +/-   ##
==========================================
+ Coverage   67.07%   67.10%   +0.02%     
==========================================
  Files        1609     1610       +1     
  Lines       64903    64973      +70     
  Branches     6868     6868              
==========================================
+ Hits        43535    43601      +66     
- Misses      19502    19506       +4     
  Partials     1866     1866
Flag Coverage Δ
hive 53.32% <0.00%> (+0.02%) ⬆️
mysql 82.22% <0.00%> (+0.02%) ⬆️
postgres 82.27% <0.00%> (+0.02%) ⬆️
presto 53.16% <0.00%> (+0.02%) ⬆️
python 82.71% <0.00%> (+0.02%) ⬆️
sqlite 81.95% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 77.81% <0.00%> (ø)
superset/models/core.py 89.48% <0.00%> (-0.03%) ⬇️
superset/css_templates/api.py 95.74% <0.00%> (ø)
superset/db_engine_specs/kusto.py 91.54% <0.00%> (ø)
superset/db_engine_specs/base.py 88.74% <0.00%> (+0.06%) ⬆️
superset/key_value/api.py 79.51% <0.00%> (+1.20%) ⬆️
superset/dashboards/filter_state/commands/get.py 91.66% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3a583...4249326. Read the comment docs.

geido
geido approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a super minor comment

superset/views/core.py Outdated Show resolved Hide resolved
villebro
villebro approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 3a58424 into apache:master Jan 11, 2022
@dpgaspar dpgaspar deleted the fix/api-logger-output branch January 11, 2022 09:30
eschutho pushed a commit that referenced this pull request Jan 27, 2022
@dpgaspar @eschutho
fix: API logger output (#17981)
d793a7e 
* fix: Improve logger messages on core API

* revert package.json change

* fix

* black

* improve log message

* improve message
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@dpgaspar @shcoderAlex
fix: API logger output (apache#17981)
ce99c53 
* fix: Improve logger messages on core API

* revert package.json change

* fix

* black

* improve log message

* improve message
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@dpgaspar @bwang221
fix: API logger output (apache#17981)
9b8cb53 
* fix: Improve logger messages on core API

* revert package.json change

* fix

* black

* improve log message

* improve message
@mistercrunch mistercrunch added 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@villebro villebro villebro approved these changes

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S v1.4.1 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpgaspar @mistercrunch @villebro @geido @eschutho