fix(native-filters): values is not sorted when setting sort option

[stephenLYZ]

SUMMARY

This problem occurs when the user creates a native filter with sorting option, because the select component defaults to using localeCompare to sort when no sortComparator is passed, which overrides the original order. Here we fix it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2022-01-10.at.3.01.56.PM.mov

after

2022-01-23.10.39.35.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: [native filters] native filter values is not sorted when select "Sort filter value" in Advance #17989
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18145 (7ff09f5) into master (0cec0c9) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master   #18145      +/-   ##
==========================================
- Coverage   65.95%   65.92%   -0.03%     
==========================================
  Files        1584     1587       +3     
  Lines       62046    62107      +61     
  Branches     6273     6284      +11     
==========================================
+ Hits        40920    40945      +25     
- Misses      19505    19541      +36     
  Partials     1621     1621              

Flag	Coverage Δ
javascript	50.86% <60.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx	68.42% <60.00%> (-0.60%)	⬇️
...rc/explore/components/controls/TextAreaControl.jsx	80.00% <0.00%> (-4.22%)	⬇️
...nd/src/explore/components/ExploreActionButtons.tsx	59.45% <0.00%> (-3.40%)	⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx	58.97% <0.00%> (-1.56%)	⬇️
superset-frontend/src/preamble.ts	0.00% <0.00%> (ø)
superset-frontend/src/views/App.tsx	0.00% <0.00%> (ø)
superset-frontend/src/setup/setupClient.ts	0.00% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <0.00%> (ø)
.../superset-ui-core/src/connection/SupersetClient.ts	100.00% <0.00%> (ø)
...rset-ui-core/src/connection/SupersetClientClass.ts	100.00% <0.00%> (ø)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cec0c9...7ff09f5. Read the comment docs.

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://34.217.78.34:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

The problem of using a sortComparator that does nothing is when we unselect a value. It will keep the previously selected value at the top.

Screen.Recording.2022-01-25.at.10.50.36.AM.mov

[stephenLYZ]

The problem of using a sortComparator that does nothing is when we unselect a value. It will keep the previously selected value at the top.

Screen.Recording.2022-01-25.at.10.50.36.AM.mov

Good catch! Adjusted.

[michael-s-molina]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.