Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove standalone #18157

Merged
merged 7 commits into from
Jan 26, 2022
Merged

fix: remove standalone #18157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e83a9b8
removed standalone
AAfghahi Jan 25, 2022
3e75c14
Update tests/integration_tests/reports/commands_tests.py
AAfghahi Jan 25, 2022
ca2b881
changed standalone
AAfghahi Jan 25, 2022
602ebba
changed standalone
AAfghahi Jan 25, 2022
565e2c1
added tests
AAfghahi Jan 25, 2022
89d7e58
made function more generic
AAfghahi Jan 26, 2022
8c7e2f8
Update superset/reports/notifications/email.py
AAfghahi Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions superset/reports/commands/execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
DashboardScreenshot,
)
from superset.utils.urls import get_url_path
from superset.utils.webdriver import DashboardStandaloneMode

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -172,7 +171,6 @@ def _get_url(
"Superset.dashboard",
user_friendly=user_friendly,
dashboard_id_or_slug=self._report_schedule.dashboard_id,
standalone=DashboardStandaloneMode.REPORT.value,
# force=force, TODO (betodealmeida) implement this
**kwargs,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/reports/commands_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ def test_when_tabs_are_selected_it_takes_screenshots_for_every_tabs(
assert dashboard_screenshot_mock.call_count == 2
for index, tab in enumerate(tabs):
assert dashboard_screenshot_mock.call_args_list[index].args == (
f"http://0.0.0.0:8080/superset/dashboard/{dashboard.id}/?standalone=3#{tab}",
f"http://0.0.0.0:8080/superset/dashboard/{dashboard.id}/?#{tab}",
AAfghahi marked this conversation as resolved.
Show resolved Hide resolved
f"{dashboard.digest}",
)
assert send_email_smtp_mock.called is True
Expand Down