-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump echarts to 5.3.0 #18162
chore: bump echarts to 5.3.0 #18162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18162 +/- ##
==========================================
- Coverage 65.95% 65.92% -0.03%
==========================================
Files 1584 1587 +3
Lines 62063 62119 +56
Branches 6273 6286 +13
==========================================
+ Hits 40934 40953 +19
- Misses 19508 19544 +36
- Partials 1621 1622 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks good to me. There is a break change that removes the default bolding emphasis effect in the line chart. https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/#removing-the-default-bolding-emphasis-effect-in-the-line-chart. Should we need to adapt it? Although I think it's not important. |
@stephenLYZ yes, good catch. I noticed it and actually thought it kind of looked cleaner, but I agree we should probably propose changing it in a separate PR and retain feature parity in this PR 👍 |
0928a14
to
6167dad
Compare
* chore: bump echarts to 5.3.0 * change to official 5.3.0 and reintroduce bold effect
* chore: bump echarts to 5.3.0 * change to official 5.3.0 and reintroduce bold effect
* chore: bump echarts to 5.3.0 * change to official 5.3.0 and reintroduce bold effect
SUMMARY
Bump ECharts to 5.3.0. See changelog here: https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/ . Changes:
alignAxis
on Mixed Timeseries chart to align y-axes when using dual axes.lineStyle
to default emphasis on Timeseries charts to retain bolding of series when hoving the chart (added TODO to revisit this later).AFTER
See how the major y-axis tick marks are now aligned:
BEFORE
Same data, ticks are unaligned:
Changelog: https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/
TODO: upgrade npm package when package is released.
TESTING INSTRUCTIONS
COUNT(*)
as metric on first query,COUNT(*) / 700.0
as metric on second query.ADDITIONAL INFORMATION