fix(teradata): LIMIT syntax #18240
Merged
fix(teradata): LIMIT syntax #18240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates to set_or_update_query_limit_top
adding apply_limit_to_sql and get_dbapi_mapped_exception
rebase for Teradata fixes for merge for 15930
rebase for issue 15930 and update to new Teradata driver
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
|
this looks like the one! |
nytai
approved these changes
Feb 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #18240 +/- ##
==========================================
+ Coverage 66.04% 66.06% +0.02%
==========================================
Files 1591 1591
Lines 62398 62547 +149
Branches 6283 6283
==========================================
+ Hits 41210 41324 +114
- Misses 19567 19602 +35
Partials 1621 1621
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
Co-authored-by: Mccush, Jack <jack.mccush@teradata.com> Co-authored-by: Jack McCush <33156805+mccushjack@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: David McNulla <david.mcnulla@teradata.com>
ofekisr
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 8, 2022
Co-authored-by: Mccush, Jack <jack.mccush@teradata.com> Co-authored-by: Jack McCush <33156805+mccushjack@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: David McNulla <david.mcnulla@teradata.com>
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
Co-authored-by: Mccush, Jack <jack.mccush@teradata.com> Co-authored-by: Jack McCush <33156805+mccushjack@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: David McNulla <david.mcnulla@teradata.com>
9 tasks
|
Hey, I'm still facing this error with the latest version of Superset. I've installed the sqlalchemy-teradata and the ODBC drivers. The connection seems to be working fine but this LIMIT keyword syntax error in SQL editor is still coming. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #15930, all of the context is there.