Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use switchboard as dependency for embedded sdk #18728

Merged
merged 1 commit into from
Feb 15, 2022
Merged

chore: use switchboard as dependency for embedded sdk #18728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions superset-embedded-sdk/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion superset-embedded-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@superset-ui/embedded-sdk",
"version": "0.1.0-alpha.1",
"version": "0.1.0-alpha.3",
"description": "SDK for embedding resources from Superset into your own application",
"access": "public",
"keywords": [
Expand Down Expand Up @@ -32,6 +32,9 @@
"last 3 safari versions",
"last 3 edge versions"
],
"dependencies": {
"@superset-ui/switchboard": "^0.18.26-0"
},
"devDependencies": {
"@babel/cli": "^7.16.8",
"@babel/core": "^7.16.12",
Expand Down
2 changes: 1 addition & 1 deletion superset-embedded-sdk/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import { IFRAME_COMMS_MESSAGE_TYPE } from './const';

// We can swap this out for the actual switchboard package once it gets published
import { Switchboard } from '../../superset-frontend/packages/superset-ui-switchboard/src/switchboard';
import { Switchboard } from '@superset-ui/switchboard';

/**
* The function to fetch a guest token from your Host App's backend server.
Expand Down
2 changes: 2 additions & 0 deletions superset-embedded-sdk/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// syntax rules
"strict": true,

"moduleResolution": "node",

// environment
"target": "es6",
"lib": ["DOM", "ESNext"],
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/packages/superset-ui-switchboard/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-frontend/packages/superset-ui-switchboard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@superset-ui/switchboard",
"version": "0.18.25",
"version": "0.18.26-0",
"description": "Switchboard is a library to make it easier to communicate across browser windows using the MessageChannel API",
"sideEffects": false,
"main": "lib/index.js",
Expand Down