Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix toc position scroll bug (#18868) #18878

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

michaelzusev
Copy link
Contributor

SUMMARY

TOC position:sticky preventing users from scrolling vertically. This change makes TOC position:fixed in the custom.css.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Position:fixed for class theme name: '.theme-doc-toc-desktop' runs in both dev and build.

ADDITIONAL INFORMATION

  • Has associated issue: Element on docs page preventing page to scroll down. #18868
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM and tested to fix the issue.

@villebro villebro requested a review from geido February 23, 2022 13:51
@srinify srinify merged commit 0edb979 into apache:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants