Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Source from Apache Foundation's website link #18894

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

paulocauca
Copy link
Contributor

@paulocauca paulocauca commented Feb 23, 2022

This PR fixes a link to latest version on Download the source from Apache Foundation's website link

from : https://dist.apache.org/repos/dist/release/superset/1.0.0/
to: https://dist.apache.org/repos/dist/release/superset/1.4.1/

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

This PR fixes a link to latest version on Download the source from Apache Foundation's website link

from : https://dist.apache.org/repos/dist/release/superset/1.0.0/
to: https://dist.apache.org/repos/dist/release/superset/1.4.1/
@@ -13,7 +13,7 @@ geospatial charts.

Here are a **few different ways you can get started with Superset**:

- Download the [source from Apache Foundation's website](https://dist.apache.org/repos/dist/release/superset/1.0.0/)
- Download the [source from Apache Foundation's website](https://dist.apache.org/repos/dist/release/superset/1.4.1/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just link to https://dist.apache.org/repos/dist/release/superset/ instead? That way we don't have to keep remembering to update it each time / people can choose the version they want etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if have a latest version should be a better way, for new downloads I don't know if oldest version would matter

@srinify srinify merged commit 7345795 into apache:master Feb 23, 2022
Copy link
Contributor Author

@paulocauca paulocauca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants