-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply url_params in global async query #18921
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18921 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 1621 1621
Lines 63057 63058 +1
Branches 6382 6382
=======================================
+ Hits 41850 41851 +1
Misses 19547 19547
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@zhaoyongjie I believe global async queries have 2 code paths due to legacy charts. Does I applied this patch to our internal fork of v1.3 and verified this fix works when requests are sent to |
Oh! Thank for pointing that out! I will check it tonight!
On Sat, Feb 26, 2022 at 08:24 Kenny Kwan ***@***.***> wrote:
@zhaoyongjie <https://github.com/zhaoyongjie> I believe global async
queries have 2 code paths
<https://github.com/apache/superset/blob/master/superset/tasks/async_queries.py#L100>.
Does superset/explore_json/data also need to be updated in this PR?
I applied this patch to our internal fork of v1.3 and verified this fix
works when requests are sent to api/v1/chart. However I still see issues
when url_params are used with GAQ and the request is sent to
superset/explore_json/data.
—
Reply to this email directly, view it on GitHub
<#18921 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPMKUX7TN4D77BCATARLITU5AMTTANCNFSM5PHAKJ5A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Best regards,
Yongjie
|
hey @zhaoyongjie. i don't believe this issue is fixed by #18960. I am on 1.5.1 which includes that PR but I'm still encountering this bug. I put up #23641 which has thus fix and also patches it for legacy charts that use |
SUMMARY
fix Jinja template is not working when the global async query is enabled.
Currently, Superset uses serialized query_obj and form_data to generate query_cache_key. But in the global async query, we didn't pass form_data. We have to get cached data from the data cache and put the cache data to
g.form_data
to fix it.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
url_params.before.mov
After
GAQ.after.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION