-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Moves components out of the commons folder #18931
chore: Moves components out of the commons folder #18931
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18931 +/- ##
==========================================
- Coverage 66.38% 66.19% -0.20%
==========================================
Files 1640 1634 -6
Lines 63514 63209 -305
Branches 6418 6409 -9
==========================================
- Hits 42164 41839 -325
- Misses 19690 19710 +20
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f157ba1
to
8ab3c39
Compare
* refactor: Moves components out of the commons folder * Fixes tests (cherry picked from commit fd4bd1e)
SUMMARY
Moves components out of the
commons
folder into their specific folders. The next step is to remove thesrc/common/components
folder.This work is part of SIP-61
TESTING INSTRUCTIONS
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION