Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves components out of the commons folder #18931

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves components out of the commons folder into their specific folders. The next step is to remove the src/common/components folder.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested review from geido and removed request for geido February 24, 2022 16:51
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #18931 (03e601d) into master (2cb3635) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head 03e601d differs from pull request most recent head 8ab3c39. Consider uploading reports for the commit 8ab3c39 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18931      +/-   ##
==========================================
- Coverage   66.38%   66.19%   -0.20%     
==========================================
  Files        1640     1634       -6     
  Lines       63514    63209     -305     
  Branches     6418     6409       -9     
==========================================
- Hits        42164    41839     -325     
- Misses      19690    19710      +20     
  Partials     1660     1660              
Flag Coverage Δ
javascript 51.02% <100.00%> (+0.02%) ⬆️
mysql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/SqlLab/components/RunQueryActionButton/index.tsx 50.00% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 71.42% <ø> (ø)
...frontend/src/SqlLab/components/SaveQuery/index.tsx 57.89% <ø> (ø)
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 19.23% <ø> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 56.39% <ø> (ø)
...rc/components/Datasource/ChangeDatasourceModal.tsx 78.68% <ø> (ø)
...rset-frontend/src/components/DeleteModal/index.tsx 84.21% <ø> (ø)
...-frontend/src/components/PopoverDropdown/index.tsx 100.00% <ø> (ø)
.../ReportModal/HeaderReportActionsDropdown/index.tsx 4.54% <ø> (ø)
...ntend/src/dashboard/components/CssEditor/index.jsx 100.00% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb3635...8ab3c39. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina force-pushed the move-components-out-of-common branch from f157ba1 to 8ab3c39 Compare February 25, 2022 12:26
@michael-s-molina michael-s-molina merged commit fd4bd1e into apache:master Feb 25, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* refactor: Moves components out of the commons folder

* Fixes tests

(cherry picked from commit fd4bd1e)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XL 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants