Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deletes the common/components folder #18999

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Mar 2, 2022

SUMMARY

This PR deletes the src/common/components folder. To do that, it reorganizes the exporting/importing of Ant Design components by clearly separating overridden components from the directed imported ones. This will allow us to review these components in the future to better support themes. It also adds comments to the src/components/index.ts file to steer the developers in the right direction when interacting with Ant Design.

This work is part of SIP-61

PS: It's not the objective of this PR to check for all direct imports of Ant Design in the components. This will probably be made in follow-up PRs.

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #18999 (425dcd7) into master (06e1e42) will increase coverage by 14.68%.
The diff coverage is 94.73%.

❗ Current head 425dcd7 differs from pull request most recent head 17e869c. Consider uploading reports for the commit 17e869c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18999       +/-   ##
===========================================
+ Coverage   51.90%   66.58%   +14.68%     
===========================================
  Files        1641     1641               
  Lines       63495    63533       +38     
  Branches     6425     6424        -1     
===========================================
+ Hits        32954    42303     +9349     
+ Misses      28861    19551     -9310     
+ Partials     1680     1679        -1     
Flag Coverage Δ
javascript 51.38% <94.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.73% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 71.42% <ø> (ø)
...frontend/src/SqlLab/components/SaveQuery/index.tsx 57.89% <ø> (ø)
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 19.23% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.44% <ø> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 61.76% <ø> (ø)
superset-frontend/src/components/Alert/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <ø> (ø)
...rc/components/Datasource/ChangeDatasourceModal.tsx 78.68% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 69.36% <ø> (ø)
... and 383 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e1e42...17e869c. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina force-pushed the delete-common-components branch from 2a84503 to 17e869c Compare March 4, 2022 16:14
@michael-s-molina michael-s-molina merged commit 3298551 into apache:master Mar 4, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XL 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants