Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): Set Drag&Drop feature flags to True by default #19046

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Mar 7, 2022

SUMMARY

Flip ENABLE_EXPLORE_DRAG_AND_DROP and ENABLE_DND_WITH_CLICK_UX feature flags to True by default. This will enable the drag and drop controls in the chart control panels in Explore pages.
Related PRs: https://github.com/apache/superset/pulls?q=is%3Apr+is%3Aclosed+drag+and+drop+in%3Atitle%2Cbody+

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [2.0] Enable D&D w/ hybrid by default #18901
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

https://app.shortcut.com/preset/story/39407/flip-dnd-feature-flags-2-0

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #19046 (22d02de) into master (299b5dc) will decrease coverage by 0.23%.
The diff coverage is 55.30%.

❗ Current head 22d02de differs from pull request most recent head e4f1686. Consider uploading reports for the commit e4f1686 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19046      +/-   ##
==========================================
- Coverage   66.56%   66.32%   -0.24%     
==========================================
  Files        1641     1641              
  Lines       63495    63476      -19     
  Branches     6425     6444      +19     
==========================================
- Hits        42265    42103     -162     
- Misses      19550    19707     +157     
+ Partials     1680     1666      -14     
Flag Coverage Δ
hive ?
mysql 81.81% <100.00%> (+<0.01%) ⬆️
postgres 81.86% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.90% <100.00%> (-0.39%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 35.89% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.36% <ø> (ø)
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...src/BigNumber/BigNumberWithTrendline/buildQuery.ts 9.09% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.73% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 71.42% <ø> (ø)
...frontend/src/SqlLab/components/SaveQuery/index.tsx 57.89% <ø> (ø)
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 19.23% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.44% <ø> (ø)
superset-frontend/src/SqlLab/fixtures.ts 100.00% <ø> (ø)
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299b5dc...e4f1686. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to fix the tests that expect these flags to be false.

@rusackas rusackas added the risk:breaking-change Issues or PRs that will introduce breaking changes label Mar 8, 2022
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 8, 2022
@kgabryje kgabryje merged commit f9c7405 into apache:master Mar 8, 2022
@john-bodley
Copy link
Member

@kgabryje would you mind also adding a line item to UPDATING.md so institutions are aware of the change?

@ktmud
Copy link
Member

ktmud commented Mar 10, 2022

I'm not sure if we should include links to an internal issue tracking tool in the PR... it feels exclusive when someone not from your org cannot open the link.

@kgabryje
Copy link
Member Author

@kgabryje would you mind also adding a line item to UPDATING.md so institutions are aware of the change?

Thanks for the reminder John! #19108

@kgabryje
Copy link
Member Author

I'm not sure if we should include links to an internal issue tracking tool in the PR... it feels exclusive when someone not from your org cannot open the link.

Agreed, let's drop that habit. Cross-linking issues in Github and Shortcut was supposed to help tracking them, but I don't think it's actually been useful. CC @rusackas

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants