feat: import/export assets commands #19217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
export_import_assets
branch
from
df7b2e0
to
7d8946f
Compare
This was referenced Mar 16, 2022
betodealmeida
force-pushed
the
refactor_import_code
branch
from
e97df46
to
625b774
Compare
betodealmeida
force-pushed
the
export_import_assets
branch
from
7d8946f
to
aa9df9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #19217 +/- ##
==========================================
+ Coverage 66.72% 66.75% +0.03%
==========================================
Files 1667 1669 +2
Lines 64222 64331 +109
Branches 6484 6484
==========================================
+ Hits 42849 42943 +94
- Misses 19692 19705 +13
- Partials 1681 1683 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
force-pushed
the
export_import_assets
branch
from
6b8956b
to
c532d79
Compare
hughhhh
reviewed
Mar 17, 2022
| # pylint: disable=unused-argument | ||
| def __init__(self, contents: Dict[str, str], *args: Any, **kwargs: Any): | ||
| self.contents = contents | ||
| self.passwords: Dict[str, str] = kwargs.get("passwords") or {} |
There was a problem hiding this comment.
Suggested change
| self.passwords: Dict[str, str] = kwargs.get("passwords") or {} | |
| self.passwords: Dict[str, str] = kwargs.get("passwords", {}) |
There was a problem hiding this comment.
Thanks for the suggestion! There's a subtle difference here that I want to capture; if passwords is passed as a keyword argument and is falsy (most likely None) we want it to be a dict, which is why I did the pattern with or instead of .get.
hughhhh
approved these changes
Mar 17, 2022
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* feat: import/export assets commands * Add overwrite test * Fix tests (cherry picked from commit 51061f0)
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR introduces two new commands (
ImportAssetsCommandandExportAssetsCommand). The commands will be used to export all assets from Superset into a ZIP file, as well as back into Superset, with the objective of managing the assets from source control.Depends on #19216.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION