Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated celery cli #19273

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Mar 21, 2022

SUMMARY

Removes deprecated celery cli. users should use celery cli itself

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@dpgaspar dpgaspar added v2.0 risk:breaking-change Issues or PRs that will introduce breaking changes labels Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #19273 (8a3c2dc) into master (dc57508) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 8a3c2dc differs from pull request most recent head 177a3e9. Consider uploading reports for the commit 177a3e9 to get more accurate results

@@            Coverage Diff             @@
##           master   #19273      +/-   ##
==========================================
+ Coverage   66.54%   66.57%   +0.03%     
==========================================
  Files        1668     1667       -1     
  Lines       64452    64418      -34     
  Branches     6503     6503              
==========================================
- Hits        42888    42886       -2     
+ Misses      19881    19849      -32     
  Partials     1683     1683              
Flag Coverage Δ
hive 52.69% <ø> (+0.04%) ⬆️
mysql 81.56% <ø> (+0.08%) ⬆️
postgres 81.61% <ø> (+0.08%) ⬆️
presto 52.54% <ø> (+0.04%) ⬆️
python 82.03% <ø> (+0.08%) ⬆️
sqlite 81.37% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.74% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc57508...177a3e9. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 I double checked that we don't have references to the deprecated commands in the docs.

@dpgaspar dpgaspar merged commit 783168e into apache:master Mar 21, 2022
@dpgaspar dpgaspar deleted the chore/remove-dep-celery-cli branch March 21, 2022 13:09
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
* chore: remove deprecated celery cli

* remove configs and UPDATING
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io risk:breaking-change Issues or PRs that will introduce breaking changes size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants