fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail

[kgabryje]

SUMMARY

When chart's request fails, we wait with displaying an error message until datasources are loaded. However, when datasources request also fails, the chart is stuck in loading state instead of displaying an error. This PR fixes that issue by passing the status of datasets request to the chart renderer, so that when datasources request fails, we display chart's error message.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Create a dashboard
2. Add a chart which request fails for whatever reason
3. Make sure that the /dashboard/${id}/datasets request fails (maybe with some intercepting tool like Requestly?)

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[villebro]

LGTM - thanks for getting to the bottom of this edge case!

[villebro]

I haven't worked on this component for a while, but I would have expected it to check the other way around, i.e. are the conditions met for displaying the error, and if not, only then display the spinner. But I don't propose changing this now as it would probably introduce unnecessary regression risk.

[codecov]

Codecov Report

Merging #19327 (469b583) into master (a8a48af) will decrease coverage by 0.00%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master   #19327      +/-   ##
==========================================
- Coverage   66.62%   66.61%   -0.01%     
==========================================
  Files        1671     1672       +1     
  Lines       64556    64545      -11     
  Branches     6506     6500       -6     
==========================================
- Hits        43009    42997      -12     
  Misses      19864    19864              
- Partials     1683     1684       +1     

Flag	Coverage Δ
javascript	51.31% <28.57%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Chart/Chart.jsx	52.45% <ø> (-1.64%)	⬇️
superset-frontend/src/dashboard/actions/hydrate.js	2.12% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx	60.20% <ø> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx	5.26% <0.00%> (-0.12%)	⬇️
...-frontend/src/dashboard/reducers/dashboardState.js	72.34% <0.00%> (-1.58%)	⬇️
...t-frontend/src/dashboard/actions/dashboardState.js	36.54% <50.00%> (+0.13%)	⬆️
...perset-frontend/src/dashboard/containers/Chart.jsx	75.00% <100.00%> (ø)
superset-frontend/src/utils/urlUtils.ts	36.73% <0.00%> (ø)
superset-frontend/src/views/components/Menu.tsx	60.00% <0.00%> (ø)
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a48af...469b583. Read the comment docs.