-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update lock + general cleanup #19350
Conversation
$ yarn | ||
$ yarn install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this doesn't change behaviour, I feel being more explicit is better
Codecov Report
@@ Coverage Diff @@
## master #19350 +/- ##
==========================================
- Coverage 66.63% 66.48% -0.16%
==========================================
Files 1675 1675
Lines 64660 64654 -6
Branches 6503 6503
==========================================
- Hits 43086 42985 -101
- Misses 19888 19983 +95
Partials 1686 1686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test this PR in the local environment. Document build works fine. LGTM!
* docs: update lock file * remove redundant npm lock file * add missing peer deps * fix TODO and bump antd * fix API spec script (cherry picked from commit 3313530)
* docs: update lock file * remove redundant npm lock file * add missing peer deps * fix TODO and bump antd * fix API spec script
SUMMARY
Many small updates to the docs package:
package-lock.json
as we're usingyarn
in CI (better to just have one workflow)^2.0.0-beta.15
to^2.0.0-beta.17
antd
(we may consider removingantd
, as it's only used for this one component)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Previously lots of warnings were emitted:
After:
TESTING INSTRUCTIONS
Make sure that docs work like before
ADDITIONAL INFORMATION