Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Explore] Adaptive formatting spelling #19359

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

kasiazjc
Copy link
Contributor

SUMMARY

We noticed that in Explore/Control panel/Customize, sections related to number/time format have incorrect spelling of the default value.

Current spelling
Adaptative formating

Changed to
Adaptive formatting

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

  1. Open time series chart in Explore
  2. Open Customize tab
  3. Scroll to chart options section
  4. Check fields: time format, time tooltip format, Y axis format

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje requested review from kgabryje and rusackas March 24, 2022 18:03
@kasiazjc kasiazjc changed the title fix: Adaptive formatting spelling fix: [Explore] Adaptive formatting spelling Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #19359 (8538318) into master (3313530) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19359   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1675     1675           
  Lines       64654    64654           
  Branches     6503     6503           
=======================================
  Hits        43092    43092           
  Misses      19876    19876           
  Partials     1686     1686           
Flag Coverage Δ
javascript 51.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-chart-controls/src/utils/D3Formatting.ts 100.00% <ø> (ø)
superset-frontend/src/explore/controls.jsx 31.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3313530...8538318. Read the comment docs.

@kgabryje kgabryje merged commit dc769a9 into apache:master Mar 24, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
Co-authored-by: Kasia Zajac <kasiazajac@Kasias-MacBook-Pro-2.local>
(cherry picked from commit dc769a9)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
Co-authored-by: Kasia Zajac <kasiazajac@Kasias-MacBook-Pro-2.local>
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants