Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated config keys and endpoints code 2.0 #19361

Merged
merged 14 commits into from
Mar 29, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Mar 24, 2022

SUMMARY

This pr removes old deprecated email job config keys and tasks. As well as remove deprecated legacy endpoint methods for sqla.

deprecated api
"/schemas/int:db_id/
"/schemas/int:db_id/<force_refresh>/"
"/csrf_token/", methods=["GET"]
"/dashboard/int:dashboard_id/published/", methods=("GET", "POST")
removes superset.task celery jobs and associated mehtods

deprecated config keys
OLD_API_CHECK_DATASET_OWNERSHIP
SCHEDULED_EMAIL_DEBUG_MODE
EMAIL_REPORTS_CRON_RESOLUTION
EMAIL_ASYNC_TIME_LIMIT_SEC
EMAIL_REPORT_BCC_ADDRESS
EMAIL_REPORTS_USER

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

User should not be able use methods and should not break new behavior for alerts.

ADDITIONAL INFORMATION

  • Has associated issue: [2.0] generally remove all code marked as "deprecated" (back end) #18897
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson changed the title chore: remove deprecated config keys and endpoints code 2.0 [WIP]chore: remove deprecated config keys and endpoints code 2.0 Mar 24, 2022
@pkdotson pkdotson added v2.0 need:qa-review Requires QA review preset:QA Preset QA team risk:breaking-change Issues or PRs that will introduce breaking changes labels Mar 25, 2022
@pkdotson pkdotson requested review from betodealmeida, dpgaspar, villebro, AAfghahi and hughhhh and removed request for betodealmeida and dpgaspar March 25, 2022 21:05
@pkdotson pkdotson changed the title [WIP]chore: remove deprecated config keys and endpoints code 2.0 chore: remove deprecated config keys and endpoints code 2.0 Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #19361 (44b3472) into master (a619cb4) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19361      +/-   ##
==========================================
+ Coverage   66.48%   66.55%   +0.06%     
==========================================
  Files        1670     1670              
  Lines       63968    63821     -147     
  Branches     6512     6512              
==========================================
- Hits        42531    42473      -58     
+ Misses      19748    19659      -89     
  Partials     1689     1689              
Flag Coverage Δ
hive 52.93% <100.00%> (+0.12%) ⬆️
mysql 81.86% <100.00%> (+0.21%) ⬆️
postgres 81.90% <100.00%> (+0.19%) ⬆️
presto 52.77% <100.00%> (+0.12%) ⬆️
python 82.33% <100.00%> (+0.20%) ⬆️
sqlite 81.67% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.41% <100.00%> (-0.17%) ⬇️
superset/connectors/sqla/views.py 91.66% <100.00%> (+27.98%) ⬆️
superset/views/core.py 76.99% <100.00%> (+1.00%) ⬆️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/exceptions.py 90.65% <0.00%> (-0.94%) ⬇️
superset/common/query_object.py 94.73% <0.00%> (-0.53%) ⬇️
superset/reports/commands/execute.py 91.14% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a619cb4...44b3472. Read the comment docs.

superset/config.py Outdated Show resolved Hide resolved
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add these suggestions + fix the pre-commit test and LGTM

@eschutho
Copy link
Member

@pkdotson this is great! Are there any other references to deprecations in 2.0 after this PR? Other deprecations are fine, we just want to make sure that there are no other references to 2.0.

@pkdotson
Copy link
Member Author

@pkdotson this is great! Are there any other references to deprecations in 2.0 after this PR? Other deprecations are fine, we just want to make sure that there are no other references to 2.0.

Yes I believe this is the rest of the 2.0 code.

@pkdotson pkdotson merged commit 0968f86 into apache:master Mar 29, 2022
@eschutho
Copy link
Member

@pkdotson this is great! Are there any other references to deprecations in 2.0 after this PR? Other deprecations are fine, we just want to make sure that there are no other references to 2.0.

Yes I believe this is the rest of the 2.0 code.

Super, thanks!

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…9361)

* remove depracted keys and associated methods

* remove api methods and tablemodel views

* remove deprecated api and unsued vars

* reremove schedules

* readd code

* fix pylint

* run black

* remove test

* core select start test

* add suggested changes
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review preset:QA Preset QA team risk:breaking-change Issues or PRs that will introduce breaking changes size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants