-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated config keys and endpoints code 2.0 #19361
chore: remove deprecated config keys and endpoints code 2.0 #19361
Conversation
…emove-deprecated-code-2_0
…emove-deprecated-code-2_0
Codecov Report
@@ Coverage Diff @@
## master #19361 +/- ##
==========================================
+ Coverage 66.48% 66.55% +0.06%
==========================================
Files 1670 1670
Lines 63968 63821 -147
Branches 6512 6512
==========================================
- Hits 42531 42473 -58
+ Misses 19748 19659 -89
Partials 1689 1689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add these suggestions + fix the pre-commit test and LGTM
@pkdotson this is great! Are there any other references to deprecations in 2.0 after this PR? Other deprecations are fine, we just want to make sure that there are no other references to 2.0. |
…emove-deprecated-code-2_0
Yes I believe this is the rest of the 2.0 code. |
…emove-deprecated-code-2_0
Super, thanks! |
…9361) * remove depracted keys and associated methods * remove api methods and tablemodel views * remove deprecated api and unsued vars * reremove schedules * readd code * fix pylint * run black * remove test * core select start test * add suggested changes
SUMMARY
This pr removes old deprecated email job config keys and tasks. As well as remove deprecated legacy endpoint methods for sqla.
deprecated api
"/schemas/int:db_id/
"/schemas/int:db_id/<force_refresh>/"
"/csrf_token/", methods=["GET"]
"/dashboard/int:dashboard_id/published/", methods=("GET", "POST")
removes superset.task celery jobs and associated mehtods
deprecated config keys
OLD_API_CHECK_DATASET_OWNERSHIP
SCHEDULED_EMAIL_DEBUG_MODE
EMAIL_REPORTS_CRON_RESOLUTION
EMAIL_ASYNC_TIME_LIMIT_SEC
EMAIL_REPORT_BCC_ADDRESS
EMAIL_REPORTS_USER
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
User should not be able use methods and should not break new behavior for alerts.
ADDITIONAL INFORMATION