Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql lab): replace the output column in the query history table #19370

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

The current output column in the Query History table in the SQL Lab currently displays the schema if the query failed.
The resulting UI is a column with "View results" button for successful queries and some seemingly random text if the query failed that lacks the appropriate context.

This PR makes some cosmetic changes that include:

  • Removing the schema for failed queries and leaving the field blank
  • Renaming the column from "output" to "results"
  • Renaming the button for successful queries from "View results" to "View"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-03-25 at 09 30 29

After:
Screen Shot 2022-03-25 at 09 48 22

TESTING INSTRUCTIONS

  1. Open the SQL Lab
  2. Execute valid and invalid queries

Ensure the results column show the View button for successful queries & nothing for failed ones.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #19370 (70657ec) into master (d693f4e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 70657ec differs from pull request most recent head 2263b02. Consider uploading reports for the commit 2263b02 to get more accurate results

@@           Coverage Diff           @@
##           master   #19370   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1681     1681           
  Lines       64408    64406    -2     
  Branches     6593     6592    -1     
=======================================
- Hits        42704    42703    -1     
  Misses      20020    20020           
+ Partials     1684     1683    -1     
Flag Coverage Δ
javascript 51.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <ø> (ø)
...rontend/src/SqlLab/components/QueryTable/index.tsx 69.64% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d693f4e...2263b02. Read the comment docs.

@diegomedina248 diegomedina248 force-pushed the fix/sql-lab-query-history-output-column branch from 2556d56 to 36e30c1 Compare April 6, 2022 11:09
@diegomedina248 diegomedina248 force-pushed the fix/sql-lab-query-history-output-column branch from 36e30c1 to 2263b02 Compare April 11, 2022 13:48
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit d4e7c65 into apache:master Apr 13, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
…19370)

* fix(sql lab): replace the output column in the query history table

* improvements

(cherry picked from commit d4e7c65)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…pache#19370)

* fix(sql lab): replace the output column in the query history table

* improvements
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants