fix(data-upload): make to change err message #19430
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19430 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 1670 1670
Lines 63884 63884
Branches 6510 6510
=======================================
Hits 42542 42542
Misses 19653 19653
Partials 1689 1689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -2810,7 +2810,7 @@ def schemas_access_for_file_upload(self) -> FlaskResponse: | |||
| get the schema access control settings for file upload in this database | |||
| """ | |||
| if not request.args.get("db_id"): | |||
| return json_error_response("No database is allowed for your csv upload") | |||
| return json_error_response("No database is allowed for your file upload") | |||
There was a problem hiding this comment.
Are you sure this is not being used when uploading a CSV as well?
@rusackas do you know if this API is being called from multiple places?
There was a problem hiding this comment.
This API is used when the csv && excel && columar file is uploaded.
There was a problem hiding this comment.
yeah, and to me this is fine, but since the message now is more generic, I just want to be sure there's no problem with it.
There was a problem hiding this comment.
I think this is fine. Approving the PR, but I'll let @yousoph merge it if she agrees, or leave a comment if she doesn't ;)
mistercrunch
added
🏷️ bot
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce this issue
Precondition: do not enable data upload for database
1, go to columnar file upload
2, observe the error msg in the columnar file upload page
ADDITIONAL INFORMATION