Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove index.less from showSavedQuery #19440

Merged
merged 2 commits into from
Apr 1, 2022
Merged

chore: Remove index.less from showSavedQuery #19440

merged 2 commits into from
Apr 1, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 30, 2022

SUMMARY

Removes the index.less from the showSavedQuery component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

I don't think this component is used anywhere and can probably be deleted

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19440 (9b21f4a) into master (fa35109) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19440      +/-   ##
==========================================
- Coverage   66.59%   66.58%   -0.01%     
==========================================
  Files        1670     1670              
  Lines       63888    63891       +3     
  Branches     6510     6510              
==========================================
  Hits        42544    42544              
- Misses      19654    19658       +4     
+ Partials     1690     1689       -1     
Flag Coverage Δ
javascript 51.32% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/showSavedQuery/index.jsx 0.00% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 41.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa35109...9b21f4a. Read the comment docs.

@michael-s-molina
Copy link
Member

I wasn't able to find where this is being used either. Can we ping some folks to see if this is being used? If not, let's remove it.

@geido
Copy link
Member Author

geido commented Mar 31, 2022

I wasn't able to find where this is being used either. Can we ping some folks to see if this is being used? If not, let's remove it.

@michael-s-molina let's keep removing unused components outside of the scope. I'll keep a note to check this as a next step

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let's remove it in a follow-up if it's not being used.

@geido geido merged commit 08aca83 into apache:master Apr 1, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants