Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Explore): Change text when saving a chart in a new dashboard #19467

Merged
merged 2 commits into from
Apr 5, 2022
Merged

chore(Explore): Change text when saving a chart in a new dashboard #19467

merged 2 commits into from
Apr 5, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 31, 2022

SUMMARY

It adds the new keywork to save actions when saving to a new dashboard.

BEFORE

Screen.Recording.2021-12-09.at.2.09.30.PM.mov

AFTER

DEV.Filtering.Vaccines.mp4

TESTING INSTRUCTIONS

  1. Open a chart
  2. Open the save chart modal
  3. Enter a new dashboard
  4. Observe the behavior

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19467 (3d52cba) into master (6b136c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19467   +/-   ##
=======================================
  Coverage   66.57%   66.58%           
=======================================
  Files        1675     1675           
  Lines       64092    64096    +4     
  Branches     6519     6522    +3     
=======================================
+ Hits        42672    42676    +4     
  Misses      19729    19729           
  Partials     1691     1691           
Flag Coverage Δ
javascript 51.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/explore/components/SaveModal.tsx 66.19% <100.00%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b136c2...3d52cba. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 1521ab3 into apache:master Apr 5, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…pache#19467)

* Change text when new dashboard

* Test buttons behavior
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants