Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the CSS files from the Partition plugin #19521

Merged
merged 3 commits into from
Apr 7, 2022
Merged

refactor: Removes the CSS files from the Partition plugin #19521

merged 3 commits into from
Apr 7, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR removes the CSS files from the Partition plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-04-04 at 3 37 54 PM

Screen Shot 2022-04-04 at 3 46 53 PM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #19521 (3927ee3) into master (c2fae82) will increase coverage by 0.04%.
The diff coverage is 70.55%.

❗ Current head 3927ee3 differs from pull request most recent head 7bd3bf6. Consider uploading reports for the commit 7bd3bf6 to get more accurate results

@@            Coverage Diff             @@
##           master   #19521      +/-   ##
==========================================
+ Coverage   66.59%   66.64%   +0.04%     
==========================================
  Files        1678     1681       +3     
  Lines       64242    64255      +13     
  Branches     6539     6561      +22     
==========================================
+ Hits        42784    42822      +38     
+ Misses      19763    19732      -31     
- Partials     1695     1701       +6
Flag Coverage Δ
javascript 51.44% <63.15%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../legacy-plugin-chart-country-map/src/CountryMap.js 0.00% <ø> (ø)
...y-plugin-chart-country-map/src/ReactCountryMap.jsx 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-partition/src/Partition.js 0.00% <ø> (ø)
...gacy-plugin-chart-partition/src/ReactPartition.jsx 0.00% <0.00%> (ø)
...y-plugin-chart-sankey-loop/src/ReactSankeyLoop.jsx 0.00% <0.00%> (ø)
.../legacy-plugin-chart-sankey-loop/src/SankeyLoop.js 0.00% <ø> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <0.00%> (-0.35%) ⬇️
...-frontend/src/components/AlteredSliceTag/index.jsx 87.87% <ø> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx 5.31% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fae82...7bd3bf6. Read the comment docs.

geido
geido reviewed Apr 6, 2022
View reviewed changes
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js Outdated
@@ -274,7 +273,7 @@ function Icicle(element, props) {
'<tr>' +
'<td>' +
'<div ' +
`style='border: 2px solid ${atNode ? 'black' : 'transparent'};` +
`style='border: 2px solid ${atNode ? 'white' : 'transparent'};` +
Copy link
Member

@geido geido Apr 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina should we use the available white from the theme vars?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I removed the condition and used the transparent border to always show the partition's colors. Previously, when the user was hovering over a partition, the leaf was white. Now the leaf obeys the color of the partition. I think it's more intuitive.

@michael-s-molina michael-s-molina merged commit 97850a8 into apache:master Apr 7, 2022
@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@michael-s-molina @philipher29
refactor: Removes the CSS files from the Partition plugin (apache#19521)
1201f97 
* refactor: Removes the CSS files from the Partition plugin

* Fixes bullet

* Always use the color of the partitions
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/L 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @geido @mistercrunch